bedeoverend / feathers-datastore

MIT License
9 stars 3 forks source link

Fixed 2 bugs + Added possibility to use credentials object for auth #9

Closed quentin-sommer closed 7 years ago

quentin-sommer commented 7 years ago

Hi,

I am using the credentials config object option to authenticate against google cloud, as specified here.

This pr just propagates options.credentials to the datastore constructor when it is truthy, allowing to use this way of authenticating.

quentin-sommer commented 7 years ago

Well, digging more into the code I found 2 bugs that I fixed in https://github.com/bedeoverend/feathers-datastore/pull/9/commits/bbd83c5b90ff54a4e7f0b11534bc7086cbc54665 and https://github.com/bedeoverend/feathers-datastore/pull/9/commits/b1c25b747e9c9c8d08d511073108ef6990d40ac1

This had the side effect of improving feathers's test success rate

Would you like me to put them in a separate PR? I rely on this changes for my application to work. @bedeoverend

bedeoverend commented 7 years ago

Great, thanks @quentin-sommer!

bedeoverend commented 7 years ago

This is included in v0.1.7

quentin-sommer commented 7 years ago

Thanks!