beders / Resty

Tiny REST client for Java and JSON.
http://beders.github.com/Resty
Apache License 2.0
272 stars 66 forks source link

Resty broken on Java 1.5 #15

Open davidekholm opened 12 years ago

davidekholm commented 12 years ago

Resty breaks when running on Java 1.5. I looked at the code for Resty.java and can see that's intended to work, but it's not enough. This is the failing code:

    try {
            java.net.CookieHandler.setDefault(new java.net.CookieManager());
    } catch (Throwable oops) {
        System.err.println("No CookieHandler. Running on GAE? Fine. No cookie support for you!");
    }

On Java 1.5, the loading of the Resty class itself, where this static code is located is breaking, so it never reaches the try-catch part. The solution is to simply put this code in a separate "CookieFix" class and instantiate such a class from the static context of the Resty class. Now you can wrap that instantiation in the try-catch loop and it will work.

beders commented 11 years ago

thanks, will put it in

davidekholm commented 11 years ago

Great!

On 20 jan 2013, at 07:13, Jochen Bedersdorfer notifications@github.com wrote:

thanks, will put it in

— Reply to this email directly or view it on GitHub.