Bugfixes for the earlier optimisation (#217)

bedezign / yii2-audit

Yii2 Audit records and displays web/cli requests, database changes, php/js errors and associated data.

https://bedezign.github.io/yii2-audit/

Other

193 stars 112 forks source link

Bugfixes for the earlier optimisation (#217) #218

Closed shalvah closed 7 years ago

shalvah commented 7 years ago

Noticed a few bugs on re-checking the code in my earlier PR (#217). Fixed them now.

array_walk doesn't always modify array keys in place
date()'s second parameter typically works with a timestamp

Sorry for the bother, @Blizzke and co. I really should stop sleep-deprived coding :confused:

Blizzke commented 7 years ago

I'll see if I can draft a new release today, pretty important that those panels work :)

For the near future I was thinking - seeing that we have this same piece of code in all the views - we might move it to a trait as a function and add it to the models or something. What do you think @cornernote ?

shalvah commented 7 years ago

That would be a good idea. Kept wondering if there was a better way while copying and pasting the code across these files @Blizzke. But, for the time being, can you help merge this PR? I don't want to be responsible for people opening new issues :blush:

Blizzke commented 7 years ago

That it was going to get merged was never in doubt :) Was just wondering in general.

shalvah commented 7 years ago

thanks Now, a release is all that's left :slightly_smiling_face: