search

bednee / cooluri

GIT repository for TYPO3 extension CoolUri
7 stars 12 forks source link

[BUGFIX] first attempt to fix SQL schema to match TYPO3 standards #34

Open schams-net opened 9 years ago

schams-net commented 9 years ago

SQL schema file updated to match TYPO3 DB standards. However, attribute "tstamp" can not be fixed without code changes due to the fact that EXT:cooluri uses datatype "timestamp" and TYPO3 uses "integer" (with UNIX timestamp value) by definition.

bednee commented 9 years ago

I can't merge it like this. It would break CoolUri functionality based on timestamp. This needs code changes to set current timestamp.

schams-net commented 9 years ago

It breaks CoolUri functionality due to my removal of: tstamp TIMESTAMP default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP Is my assumption correct?

bednee commented 9 years ago

Exactly

bednee commented 9 years ago

How about this: https://forge.typo3.org/issues/64297#change-275366

schams-net commented 9 years ago

I tested the suggested SQL script, but to no avail. See my note and screenshots at https://forge.typo3.org/issues/64297#note-3

mbrodala commented 8 years ago

Even though the automatic management of this field by the SQL server is neat, how about doing this like the rest of TYPO3 and manually passing the current timestamp on insert/update?

schams-net commented 8 years ago

@mbrodala: +1

I started updating EXT:cooluri and implemented exactly this (plus a few other small changes to make the extension more TYPO3-conform such as proper DB table names). However I have not had the time to fully test the new version and there are still two warnings in the Install Tool when executing the DB compare.

https://github.com/schams-net/cooluri/tree/implement-proper-db-schema

bednee commented 8 years ago

You know, CoolUri wasn't at first meant to be TYPO3 extension at all. Then I added integration. Eventually. CoolUri is used only in TYPO3 and no other project uses it. But it could. Chaning tablenames isn't really a big deal. Managing timestamps is big change that should be properly tested.

schams-net commented 8 years ago

@bednee well, fact is that CoolURI became very popular in the TYPO3 universe. 23,700+ downloads from TER is proof enough. If you do not rely on other projects using the code base, this would be a good argument for focusing on TYPO3 CMS and make it even better - e.g. by following the TYPO3 guidelines (DB tables, storing timestamps programmatically, etc.). That's what I had in mind when I started implementing the updates.

CoolURI as a TYPO3 extension is pretty cool. Thanks for sharing this with the community. I would love to see some further improvements and a merge of my suggested changes after someone tested them thoroughly of course.