bednee / cooluri

GIT repository for TYPO3 extension CoolUri
7 stars 12 forks source link

allow XCLASSing for Bednarik\Cooluri\Core\Translate #51

Open ferbar opened 8 years ago

bednee commented 8 years ago

This is core class, I don't think it's a good idea to xclass it. Why do you need it?

h4de5 commented 7 years ago

would need this too. whenever we need to extend the functionality and options of cooluri that cannot be done through the config file.

bednee commented 7 years ago

What kind of functionality you need? Could others use this functionality? If so, how about making it part of the core, just raise a pull request and I will review the code.

Jan

⁣Odesláno z TypeApp ​

    1. 2017 16:43, 16:43, Andi notifications@github.com napsal/a:

      would need this too. whenever we need to extend the functionality and options of cooluri that cannot be done through the config file.

      -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/bednee/cooluri/pull/51#issuecomment-283689144

h4de5 commented 7 years ago

I going through some diffs right now :)

I am not sure, how useful this changes would be to the public. ( thus i agree a prompt in the backend would help everyone ;) ) We are working with cooluri for several years now and those changes where made due to customers requests. We patched cooluri on our side to enable those changes, but having more options in extending it using a proper "typo3" way would be appreciated.