Issue with combination of CoolURI, Multidomain and SSL/HTTPS

bednee / cooluri

GIT repository for TYPO3 extension CoolUri

7 stars 12 forks source link

Issue with combination of CoolURI, Multidomain and SSL/HTTPS #58

Open JoJoAction opened 7 years ago

JoJoAction commented 7 years ago

In the latest stable release (1.1.2) there is a problem when it comes to the combination of CoolURI, Multidomain and SSL/HTTPS. In "CoolUri.php", lines 322 and 471, the URL is preceeded statically by "http://", instead of checking if "https://" would be more appropriate. This behaviour has been described before here almost 6 years ago.

bednee commented 7 years ago

I guess using URLs without protocol just as implemented in this PR https://github.com/bednee/cooluri/pull/55 would fix this issue. Can you try to delete "http:" from the source and test it?

JoJoAction commented 7 years ago

Thank you, I implemented it in lines 322 and 471 of file "Classes/Integration/CoolUri.php". It seems to work, I will keep an eye on it.