search

bedrocklinux / bedrocklinux-website

This tracks website development for Bedrock Linux
https://bedrocklinux.org
64 stars 18 forks source link

Container is broken on pages with long commands #18

Open tylersamples opened 8 years ago

tylersamples commented 8 years ago

For instance on: http://bedrocklinux.org/1.0beta2/quickstart.html Lines such as this are too long and break the display of the site:

# [ -e "/etc/sudoers" ] && echo 'Defaults secure_path="/bedrock/bin:/bedrock/sbin:/bedrock/brpath/pin/bin:/bedrock/brpath/pin/sbin:/usr/local/bin:/opt/bin:/usr/bin:/bin:/usr/local/sbin:/opt/sbin:/usr/sbin:/sbin:/bedrock/brpath/bin:/bedrock/brpath/sbin"' >> /etc/sudoers

If you scroll horizontally you end up getting something like this: image

Adding word-wrap: break-word; to ul.rcmd would fix this. Is this issue intentional to prevent readers from potentially entering new lines where they shouldn't? I'd more than happily send a PR for any suggested fixes.

paradigm commented 8 years ago

That wasn't intentional - more a result of my lack of skill/experience with HTML/CSS. I expect that the $/# "prompts" on the code lines clarify where the line breaks go - so long as copy/paste works I'm content.

As is, the example you pointed out wraps for me in Firefox, but not in Chrome. Per your recommendation, adding word-wrap:break-word; to ul.rcmd fixes this. With that in place, it still visually looks like one line - I'm not overly concerned users will think it's multiple lines - and it still copy/pastes as one line. Looks good to me!

With an eye out for long lines, I found other points of concern to which we might need to make other changes as well, such as

# /bedrock/libexec/setcap cap_sys_chroot=ep /bedrock/bin/brc

on the same page. Maybe we need word-wrap:break-word; for *.rcmd and *.cmd?

If you want to tackle this and make a PR so your name shows up in the git logs, I'll be happy to accept one. If you just wanted to point this out and are content with me fixing it, I can likely dig into this and figure it out now that I know it's a point of concern to look out for.

tylersamples commented 8 years ago

@paradigm ping on this, I submitted a pull request to fix these issues. Let me know if you have any questions.