search

bedros / libjingle

Automatically exported from code.google.com/p/libjingle
0 stars 0 forks source link

Wasted work in P2PTransportChannel::UpdateChannelState() #449

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The problem appears in r4414. I have attached a simple one-line patch that 
fixes it.

In method P2PTransportChannel::UpdateChannelState() in 
p2p/base/p2ptransportchannel.cc, the loop on line 971 should break immediately 
after "readable" is set to "true". All the iterations after "readable" is set 
to "true" do not perform any useful work, at best they just set "readable" 
again to "true".

Original issue reported on code.google.com by pochang0...@gmail.com on 5 Aug 2013 at 1:34

Attachments:

GoogleCodeExporter commented 9 years ago 
Changelist uploaded on:
https://webrtc-codereview.appspot.com/1959004/

Original comment by pochang0...@gmail.com on 16 Aug 2013 at 2:11