search

bee-san / Ares

Automated decoding of encrypted text without knowing the key or ciphers used
MIT License
567 stars 27 forks source link

[BUG] When the plaintext has significant invisible characters alert the user #134

Open bee-san opened 1 year ago

bee-san commented 1 year ago

Currently we print to the terminal which may obscure invisible characters. I propose that when the plaintext is made up of 20 or 30% invisible characters we alert the user with something like:

❓ 41% of the plaintext is invisible characters, would you like to save to a file instead? (y/N)
y

Please enter a filename: (default: $HOME/ares_text.txt)
bee-san commented 1 year ago

We should also offer the ability to write to a file if the output is of a certain length (I'd say maybe 100 chars!)

RenTrieu commented 11 months ago

Hello, I was interested in working on this issue. Is this still available to work on?

gregorni commented 10 months ago

@RenTrieu I haven't seen any active development by the maintainers of this repo in the last 5 months, so I'm not sure your pull request will be reviewed if you open one. You can still try if you think it'll be worth it for you.

On that note, @bee-san @SkeletalDemise Has something happened that this repository hasn't been update in such a long time? It was quite active when I last contributed.

bee-san commented 10 months ago

Oh I forgot to reply, it's xmas :) It will be reviewed, all pull requests are reviewd.

The CI cargo deny issues are in the realm of @SkeletalDemise , who knows way more about cargo deny than i do :( It may be easier to just rip the whole thing out rather than fix it.

@RenTrieu feel free to contribute a PR!

We have a Discord we talk in quite a lot http://discord.skerritt.blog

RenTrieu commented 10 months ago

Sounds good! I'll get working on the issue. I look forward to making a PR!