search

bee-san / pyWhat

🐸 Identify anything. pyWhat easily lets you identify emails, IP addresses, and more. Feed it a .pcap file or some text and it'll tell you what it is! 🧙‍♀️
MIT License
6.59k stars 349 forks source link

No output until the searching is complete #189

Open caraar12345 opened 3 years ago

caraar12345 commented 3 years ago

Is your feature request related to a problem? Please describe. It feels a tad strange to run a pyWhat command and get no output at all until it's complete. With a really large file, pyWhat can understandably take a long time; it's hard to tell if it's crashed or just working silently.

Describe the solution you'd like Ideally, progress bars would be awesome. But not too complex; counting each individual regex as a full "unit" would work fine. By this I mean, with 100 regexes to run on a file, one regex = 1%. This translates to multiple files too if a second progress bar was used - with 8 files, 1 file is worth 12.5%.

Describe alternatives you've considered Maybe pyWhat could output each regex as it completes it along with an initial summary of what it's going to do. For example:

Starting pyWhat...
Regexes: 150
Amazon AWS access key ✅

Additional context Discussed on Discord 😄

tres1N commented 3 years ago

Hey! I would definitely like to work on this issue:) Can you assign it to me?

ghost commented 3 years ago

Unassigned due to no activity.

ghost commented 2 years ago

A little update on this issue😅. I suggest making identify method a generator. This way a user can call it and get an instant match. The problem is that sorting code may need changes. The same applies to printing. I am not sure about displaying status, maybe we should convert the position of the first character in a match to the percentage (compare it with the total length of input).

definitelynotchirag commented 3 weeks ago

@caraar12345 @amadejpapez Hey can i work on this if still an issue?

caraar12345 commented 3 weeks ago

Hey can i work on this if still an issue?

@bee-san would be the person to ask!