search

bee-san / pyWhat

🐸 Identify anything. pyWhat easily lets you identify emails, IP addresses, and more. Feed it a .pcap file or some text and it'll tell you what it is! 🧙‍♀️
MIT License
6.52k stars 350 forks source link

Discussion about pywhat output order and usability of given matches #232

Open ghost opened 2 years ago

ghost commented 2 years ago

The regexes clearly have some false positives, so we should improve the output order, add interactive mode or something like that. @bee-san @amadejpapez thoughts?

If you have any ideas or proposals, please post it here.

Originally posted by @piatrashkakanstantinass in https://github.com/bee-san/pyWhat/pull/225#issuecomment-965011225

bee-san commented 2 years ago

I imagine a interactive mode like:

There are 157 results, would you like to only show the top 10?

Would work out quite well. For single items (i.e pywhat text) the higher the rarity, the more likely it should be as it wouldn't have matched. Only showing the top 5% or so would work well.

I haven't given much thought to files though, although the same concept can be applied 😄

ghost commented 2 years ago

I imagine a interactive mode like:

There are 157 results, would you like to only show the top 10?

Would work out quite well. For single items (i.e pywhat text) the higher the rarity, the more likely it should be as it wouldn't have matched. Only showing the top 5% or so would work well.

I haven't given much thought to files though, although the same concept can be applied 😄

The good question is what should a user do to get the next results or results with a specific tag, name, etc.?

bee-san commented 2 years ago

I wrote a proposal specifically on a Kibana like mode https://github.com/bee-san/pyWhat/issues/233