search

beeb / pancaketrade

Limit orders for PancakeSwap
GNU General Public License v3.0
200 stars 92 forks source link

[feature] auto slippage or set several slippage #46

Open ahdsafw opened 2 years ago

ahdsafw commented 2 years ago

Hi , could you please add smart try different slippage function when buy/sell now or make order ? sometimes , the slippage often changes very large such as 10-13% during volatile price . so ,i wish a feature that allows me to set slippage scope when i bue/sell now or make order. Thanks.

beeb commented 2 years ago

How do you propose to implement this? Please describe the algorithm in pseudo-code.

beeb commented 2 years ago

Please note that you can customize the slippage for each order that you make with "+ Create order" button or /addorder command. The slippage is the maximum price movement that you are willing to accept (includes any token transaction tax that might be applied). It doesn't need a range. Having a range (scope like you said) is the same as having one value. If you expect price change 10-13% then put your slippage at 13+%.

ahdsafw commented 2 years ago

thank you

ssergiio commented 2 years ago

@beeb

  1. buy/sell order is set
  2. request to honeypot.is/?address=TOKENADDRESS is made
  3. data is parsed to get actual buy/sell tax
  4. slippage of the token gets changed according to the parsed data
  5. buy/sell order is triggered
beeb commented 2 years ago

I do not like the idea of relying on an external api for this, as I've observed they have hardcoded the binance rpc url in there which is known to frequently be out of sync when the network is busy. Also, this service only works for BNB LP (they have a separate page for BUSD, but none for USDT AFAIK). They use a smart contract in the background to perform these checks. If anyone knows how they do it, it would be feasible to make a more generic and better version which pancaketrade could query with an rpc call directly.

beeb commented 2 years ago

Also, I think this is dangerous as some token developers implement high tax at launch to prevent bots, which if applied without any safeguard, could lead to lost funds