Track max and min of tokens

[osatien]

• [x] I have searched the issues of this repo and believe that this is not a duplicate.
• [x] I have read the Readme and believe that my question is not covered.

Feature Request

As we are reading price every 5s can we have record of max and min during last x? Being x something configurable per token perhaps?

[beeb]

The only reasonable way to do this without becoming a charting software with a huge database of all the price history, would be to store the min and max price together with the times they occured inside the token record.

I have trouble to see how this would be more valuable than clicking one of the chart links and make your own personnalized assessment of the price movement.

What I want implement however, are price movement alerts as described in https://github.com/beeb/pancaketrade/issues/27 but I lack the time to implement new features these days.

[osatien]

The problem I see is that I don't know the price when the alert start. And when it says going to buy order 24 would be nice to see the token the alert price and the real in the exchange.

Good job in any case!!

I wanted to add support for two admins but having both message together would be troublesome.

I have added support to apprise through env var so I can be messaged with pushover when it buys or sells

El lun., 6 dic. 2021 18:13, Valentin Bersier @.***> escribió:

The only reasonable way to do this without becoming a charting software with a huge database of all the price history, would be to store the min and max price together with the times they occured inside the token record.

I have trouble to see how this would be more valuable than clicking one of the chart links and make your own personnalized assessment of the price movement.

What I want implement however, are price movement alerts as described in

27 https://github.com/beeb/pancaketrade/issues/27 but I lack the time

to implement new features these days.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/beeb/pancaketrade/issues/66#issuecomment-986979246, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV7I76OLBLTGL7EJONG5Y3UPTVK5ANCNFSM5JIGQGSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[osatien]

Well I didn't have in mind any bd just something with min and max price in mem and reset every day at 0 but perhaps is related to price alert

[beeb]

What do you mean by "alert price"?

[osatien]

the price at which the alerts started

On Fri, Dec 10, 2021 at 8:39 AM Valentin Bersier @.***> wrote:

What do you mean by "alert price"?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/beeb/pancaketrade/issues/66#issuecomment-990693482, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV7I72U2M5E4JEBR3E4XVTUQGVE3ANCNFSM5JIGQGSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[beeb]

I don't know what you mean by "alert" since there is no alert feature as of yet. There are tokens and orders which react to price in various ways.

[osatien]

It's ok .... When I set limit order .... I put down prize and I am talking about this signals. When I buy I have modified to send alert ... So this is why I call them alerts

El vie., 10 dic. 2021 19:07, Valentin Bersier @.***> escribió:

I don't know what you mean by "alert" since there is no alert feature as of yet. There are tokens and orders which react to price in various ways.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/beeb/pancaketrade/issues/66#issuecomment-991183990, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV7I7ZTLLXPLTQ7SCLZ3FTUQI6UJANCNFSM5JIGQGSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[beeb]

So if I understand correctly, you would like to see more information on one of the messages that are produced by the bot. Can you show which message (copy-paste or screenshot) you would like to change and what the new content should be?

[osatien]

🔸 Trying to buy for 0.2 BNB of NMS...

El vie., 10 dic. 2021 20:05, Valentin Bersier @.***> escribió:

So if I understand correctly, you would like to see more information on one of the messages that are produced by the bot. Can you show which message (copy-paste or screenshot) you would like to change and what the new content should be?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/beeb/pancaketrade/issues/66#issuecomment-991223065, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV7I73CDQUAWH5ZODESOC3UQJFP5ANCNFSM5JIGQGSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[beeb]

Yes, this message is shown while the transaction is pending. After that you should get a summary of which order executed, and then how much money you got from the sale, as well as the effective price (after any tax) that you got the tokens for. I really can't understand what you want, you need to be more clear. Probably a language barrier thing too. Try in spanish, I think I would understand because my mother is spanish.

[osatien]

I don't mind ... I know that I explain myself very bad and it should be the same in Spanish 🤣

When it is ok no problem. But when the TX fails ... I don't know nothing.

And when the pool has high variability ... I don't know the price it was

El vie., 10 dic. 2021 20:29, Valentin Bersier @.***> escribió:

Yes, this message is shown while the transaction is pending. After that you should get a summary of which order executed, and then how much money you got from the sale, as well as the effective price (after any tax) that you got the tokens for. I really can't understand what you want, you need to be more clear. Probably a language barrier thing too. Try in spanish, I think I would understand because my mother is spanish.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/beeb/pancaketrade/issues/66#issuecomment-991238039, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV7I77DMDEFXE5V64S7QWTUQJIH7ANCNFSM5JIGQGSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.