search

beeb / pancaketrade

Limit orders for PancakeSwap
GNU General Public License v3.0
200 stars 91 forks source link

Config monitor interval #9

Closed DigiTecK3D closed 3 years ago

DigiTecK3D commented 3 years ago

I noticed an issue when you change the monitor_interval in the config file to 1 the bot crashes and gives a typerror File "C:\Users\migue\Documents\GitHub\pancaketrade\.venv\lib\site-packages\apscheduler\job.py", line 196, in _modify raise TypeError('misfire_grace_time must be either None or a positive integer') TypeError: misfire_grace_time must be either None or a positive integer

image

beeb commented 3 years ago

Hey, thanks for catching this! It's an easy fix, I'll look into it today

DigiTecK3D commented 3 years ago

Sounds great! Thank you!

beeb commented 3 years ago

Should be fixed in https://github.com/beeb/pancaketrade/commit/c975d1060cdb6474cb317e12b7d68f8f6d68c15b

Will test soon

DigiTecK3D commented 3 years ago

Perfect, I’ll grab the change and test it out! Thanks again!

DigiTecK3D commented 3 years ago

Pulled the changed and tested it, everything is working fine. Thanks for the fix!

DigiTecK3D commented 3 years ago

not sure if this has anything to do with the interval thing, but got this from testing a buy right now. image

beeb commented 3 years ago

This is expected from smaller intervals, as it might take more than 1 second to check the price of the token. It skips iterations when a job is already running.