search

beedesk / jQTouch

jQT + actively maintained + exclusive features (iPad layout, iscroll, tons of css enhancements, page events, param passing between pages, radio button, grid, mail, improved page history management etc.)
http://bit.ly/beedesk-jqt
MIT License
72 stars 13 forks source link

select tags in scrollpane unresponsive #15

Closed ghost closed 13 years ago

ghost commented 13 years ago

Hi, I just implemented your awesome jQTouch fork in my project and it's by far the best implementation I've found so far. The only issue I can't seem to work around is when there's a select tag in a form that resides in a s-scrollpane it doesn't register my clicks/taps. Even when I just apply s-scrollwrapper to the parent object the selects stop functioning. Am I missing something here? Any insights?

thomasyip commented 13 years ago

Thanks for reporting.

I just reprod the problem. Look like it is an usual integration issue with iScroll. (it tried to do e.preventDefault() that stop input from working.)

Watch for my push.

thomasyip commented 13 years ago

Apply this patch, if you're in hurry. I will test it a bit more and lump this with some other changes.

Index: src/html/jslib/jqtouch/extensions/iscroll/iscroll.js
===================================================================
--- src/html/jslib/jqtouch/extensions/iscroll/iscroll.js        (revision 1243)
+++ src/html/jslib/jqtouch/extensions/iscroll/iscroll.js        (working copy)
@@ -261,7 +261,7 @@

                that.moved = false;

-               e.preventDefault();
+               //e.preventDefault();

                if (hasTouch && e.touches.length == 2 && that.options.zoom && hasGesture) {
                        that.originX = m.abs(e.touches[0].pageX + e.touches[1].pageX - that.wrapperOffsetLeft*2) / 2 - t
hat.x;

</

thomasyip commented 13 years ago

Fixed. (and updated to iscroll 4)

https://github.com/beedesk/jQTouch/commit/7a66f4a53ec622954031b91f606ab7a95d7f95f1

ghost commented 13 years ago

Thanks a lot I'll implement your latest update into my app now!

ghost commented 13 years ago

Damn! It seems like now the checkboxes don't function properly anymore. Upon touch they change and then return to their previous status. The issue only occurs when they are in an iScroll container on iOS Simulator and iPhone. Chrome Browser doesn't show this behavior.

thomasyip commented 13 years ago

Have you pull the whole branch. What you have seemed might be related to the same events sent to the checkbox twice. It should have fixed.

ghost commented 13 years ago

Aj, ok I only exchanged parts, so I better pull in the whole project. Thanks!

ghost commented 13 years ago

Hmm, pulled the whole branch but now there seem to be double select issues all over the place. Checkboxes in iScroll still revert back to original state, buttons in navbar have a weird delay on selection (it seems they don't register the first tap, but then there's another one programmatically that selects them), radio buttons flash twice with a blue background color, before being selected...

Basically all form elements are extremely slow now (with or without iScroll) and the blue highlight on tap is new as well, isn't it?

What am I missing here? My HTML is pretty standard and stripped down to the necessary. Pulling my hair out! Would be glad if you could shed some light!

thomasyip commented 13 years ago

Can you try running the main demos to see if you have the same problem? I just try it on mine, it works pretty fine.

On Tue, Mar 15, 2011 at 5:25 AM, Azathoth reply@reply.github.com wrote:

to original state, button