Update for getDerivedStateFromProps

beefe / react-native-actionsheet

An elegant ActionSheet component for React Native.

MIT License

1.35k stars 343 forks source link

Update for getDerivedStateFromProps #88

Open walaman opened 4 years ago

walaman commented 4 years ago

Trying to fix issue https://github.com/beefe/react-native-actionsheet/issues/84

Changed

_calculateHeight() && get styles() out of class
Use getDerivedStateFromProps instead of componentWillReceiveProps

EJohnF commented 4 years ago

for me seems to work, thanks :)

MaxInMoon commented 4 years ago

Could it be mergeable?

lukasa1993 commented 4 years ago

will this be merged?

klimdead commented 4 years ago

Any updates for merge?

pke commented 4 years ago

Thanks for the PR. Maybe @xiaoyann could merge?

Santo-dev commented 4 years ago

Maybe @xwenliang @skyRen @xiaoyann @chunyanzhu @penghongsun or @skinTest can merge? Thanks in advance guys, it would be great for all of us. And Thank you @walaman for your work.

walaman commented 4 years ago

@walaman Is it possible to merge ? It would be great for all of us. Thanks in advance.

Sorry Im not the owner, and I don't have the permission to merge it. Seems this project have been abandoned and outdate, it would be better to rewrite using react hook

alessiocancian commented 3 years ago

I released the fix to npm, read #131