Keep consistent naming with the price oracle IDs

beefyfinance / beefy-api

Simple API for BeefyFinance

https://api.beefy.finance

MIT License

117 stars 201 forks source link

Keep consistent naming with the price oracle IDs #90

Closed sirbeefalot closed 2 years ago

sirbeefalot commented 3 years ago

We used to use Pancakeswap's API at thttps://api.pancakeswap.finance/api/v1/price as a price oracle. Now we're using smart contract oracles directly. It seems like a good opportunity to stop using their inconsistent naming of mixing uppercase with capitalised or lowercase ids and move all our IDs to be uppercase.

The app/cowllector/dashboad repos might have to be updated as well.

tonyito commented 3 years ago

This would involve changing the oracle IDs of AMM LP and Token price fetching and not coingecko, correct?