Closed yazun closed 2 years ago
Actually the assertion failure is correct as we lowered accuracy for the sake of the test (so jvm properly executes vanilla java code).
Thank you @yazun for the report.
Can you confirm that the newest version works for you?
https://mvnrepository.com/artifact/org.ow2.asm/asm/9.2
The dependency is located here: https://github.com/beehive-lab/TornadoVM/blob/c7893f594cb4710a93495b279aa393845ff47991/tornado-annotation/pom.xml#L44
If it works for you, please, feel free to open a PR with this change.
Update: ok I just saw the connection with #153 . Could you please open a PR with this change?
All PRs are submitted to the develop
branch.
Sorry, Just realized I created merge request with master, will redo with develop
branch.
Dont worry, I can edit it.
Describe the bug
We are trying to naively port our standard to start with TornadoVM using JDK17 and dev-013 from develop branch. We ported a selected algorithm but are unable to run it.
Code compiles fine:
but when trying to run we get puzzling error related to asm not handling java17 (it started jdk17 support with ver 8 or 9 I think), as the project has been recompiled with jdk17:
The failed test is the one that calling computeGPU method, so somehow it works but with relatively big deviation from vanila jdk17 code as a result.
How To Reproduce running a junit test using bare java cmd (not all jars are needed for the test but are needed by our stack):
Expected behavior
Tornadovm not complaining about jdk version mismatch, test running using a generated kernel (does not seem the case here).
A clear and concise description of what you expected to happen.
Computing system setup (please complete the following information):
Number of Tornado drivers: 1 Driver: OpenCL Total number of OpenCL devices : 2 Tornado device=0:0 OpenCL -- [Intel(R) CPU Runtime for OpenCL(TM) Applications] -- Intel(R) Xeon(R) CPU E3-1585L v5 @ 3.00GHz Global Memory Size: 62.8 GB Local Memory Size: 32.0 KB Workgroup Dimensions: 3 Total Number of Block Threads: 8192 Max WorkGroup Configuration: [8192, 8192, 8192] Device OpenCL C version: OpenCL C 2.0
Tornado device=0:1 OpenCL -- [Intel(R) OpenCL HD Graphics] -- Intel(R) Iris(TM) Pro Graphics P580 [0x193a] Global Memory Size: 50.2 GB Local Memory Size: 64.0 KB Workgroup Dimensions: 3 Total Number of Block Threads: 256 Max WorkGroup Configuration: [256, 256, 256] Device OpenCL C version: OpenCL C 3.0