Closed ShAlireza closed 10 months ago
Thank you for your contributions. LGTM.
The way to check now is as follows:
$ tornado-benchmarks.py --skipSequential --profiler silent
It seems we also need to update the documentation here:https://tornadovm.readthedocs.io/en/latest/benchmarking.html#how-to-run
We will do that.
Description
The --profiler flag didn't work, since when enabled by the user, the flag was added to JVM options, however, it should be placed in front of the tornado command and not JVM options.
Hence, the options variable is updated to two separate variables: jvm_options and tornado_options, so every option will be placed in its right place.
Problem description
JVM didn't recognize the --enableProfiler flag and showed the following error:
You can regenerate the error by running the following command:
Backend/s tested
Mark the backends affected by this PR.
OS tested
Mark the OS where this PR is tested.
Did you check on FPGAs?
If it is applicable, check your changes on FPGAs.
How to test the new patch?
You can run the tornado-benchmarks.py script just like the following example:
tornado-benchmarks.py --skipSequential --profiler console
And profiler output will be displayed on the console.