search

beehive-lab / TornadoVM

TornadoVM: A practical and efficient heterogeneous programming framework for managed languages
https://www.tornadovm.org
Apache License 2.0
1.18k stars 112 forks source link

Update and fix virtual device unit-tests to comply with codegen changes #318

Closed mikepapadim closed 7 months ago

mikepapadim commented 7 months ago

Description

Since support for fp16 added extra intrinsics for kernel code gen, static tests for virtual devices were failing. This PR updates the pre-generated kernels to compy with the latest codegen.

Problem description

Backend/s tested

Mark the backends affected by this PR.

OS tested

Mark the OS where this PR is tested.

How to test the new patch?

make jdk21
make tests
jjfumero commented 7 months ago

LGTM. It passes the unittests.

tornado -ea  --jvm "-Xmx6g -Dtornado.recover.bailout=False -Dtornado.unittests.verbose=True  -Dtornado.device.desc=/home/juan/manchester/tornado/tornado/bin/sdk/examples/virtual-device-GPU.json -Dtornado.print.kernel=True -Dtornado.virtual.device=True -Dtornado.print.kernel.dir=/home/juan/manchester/tornado/tornado/bin/sdk/virtualKernelOut.out"  -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  --params "uk.ac.manchester.tornado.unittests.virtual.TestVirtualDeviceKernel#testVirtualDeviceKernelGPU"
WARNING: Using incubator modules: jdk.incubator.vector

Test: class uk.ac.manchester.tornado.unittests.virtual.TestVirtualDeviceKernel#testVirtualDeviceKernelGPU
    Running test: testVirtualDeviceKernelGPU ................  [PASS] 
Test ran: 1, Failed: 0, Unsupported: 0

tornado -ea  --jvm "-Xmx6g -Dtornado.recover.bailout=False -Dtornado.unittests.verbose=True  -Dtornado.device.desc=/home/juan/manchester/tornado/tornado/bin/sdk/examples/virtual-device-CPU.json -Dtornado.print.kernel=True -Dtornado.virtual.device=True -Dtornado.print.kernel.dir=/home/juan/manchester/tornado/tornado/bin/sdk/virtualKernelOut.out"  -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  --params "uk.ac.manchester.tornado.unittests.virtual.TestVirtualDeviceKernel#testVirtualDeviceKernelCPU"
WARNING: Using incubator modules: jdk.incubator.vector

Test: class uk.ac.manchester.tornado.unittests.virtual.TestVirtualDeviceKernel#testVirtualDeviceKernelCPU
    Running test: testVirtualDeviceKernelCPU ................  [PASS] 
Test ran: 1, Failed: 0, Unsupported: 0

tornado -ea  --jvm "-Xmx6g -Dtornado.recover.bailout=False -Dtornado.unittests.verbose=True  -Dtornado.device.desc=/home/juan/manchester/tornado/tornado/bin/sdk/examples/virtual-device-GPU.json -Dtornado.virtual.device=True -Dtornado.feature.extraction=True -Dtornado.features.dump.dir=/home/juan/manchester/tornado/tornado/bin/sdk/virtualFeaturesOut.out"  -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  --params "uk.ac.manchester.tornado.unittests.virtual.TestVirtualDeviceFeatureExtraction#testVirtualDeviceFeaturesGPU"
WARNING: Using incubator modules: jdk.incubator.vector

Test: class uk.ac.manchester.tornado.unittests.virtual.TestVirtualDeviceFeatureExtraction#testVirtualDeviceFeaturesGPU
    Running test: testVirtualDeviceFeaturesGPU ................  [PASS] 
Test ran: 1, Failed: 0, Unsupported: 0

tornado -ea  --jvm "-Xmx6g -Dtornado.recover.bailout=False -Dtornado.unittests.verbose=True  -Dtornado.device.desc=/home/juan/manchester/tornado/tornado/bin/sdk/examples/virtual-device-CPU.json -Dtornado.virtual.device=True -Dtornado.feature.extraction=True -Dtornado.features.dump.dir=/home/juan/manchester/tornado/tornado/bin/sdk/virtualFeaturesOut.out"  -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  --params "uk.ac.manchester.tornado.unittests.virtual.TestVirtualDeviceFeatureExtraction#testVirtualDeviceFeaturesCPU"
WARNING: Using incubator modules: jdk.incubator.vector

Test: class uk.ac.manchester.tornado.unittests.virtual.TestVirtualDeviceFeatureExtraction#testVirtualDeviceFeaturesCPU
    Running test: testVirtualDeviceFeaturesCPU ................  [PASS] 
Test ran: 1, Failed: 0, Unsupported: 0