beehive-lab / TornadoVM

TornadoVM: A practical and efficient heterogeneous programming framework for managed languages
https://www.tornadovm.org
Apache License 2.0
1.18k stars 112 forks source link

[tests] half-type (fp16) tests added in the whitelist #319

Closed jjfumero closed 7 months ago

jjfumero commented 7 months ago

Description

This PR adds the FP16 for the OpenCL tests in the white list. The reason is that, for some devices, even though the half types are not supported, it is possible to perform FP16 computations. Thus, the TornadoVM runtime cannot throw an exception just by looking at the OpenCL properties of the device. Rather, it continues the execution of the kernel and the driver will launch an error code is the kernel is not supported.

This does not mean that the kernel is not correct. For this reason, we add these FP16 to the white list of unit-tests.

Backend/s tested

This PR only affects the OpenCL backend.

OS tested

Mark the OS where this PR is tested.

Did you check on FPGAs?

If it is applicable, check your changes on FPGAs.

How to test the new patch?

make 
tornado -ea  --jvm "-Xmx6g -Dtornado.recover.bailout=False -Dtornado.unittests.verbose=True "  -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  --params "uk.ac.manchester.tornado.unittests.arrays.TestArrays"