search

beehive-lab / TornadoVM

TornadoVM: A practical and efficient heterogeneous programming framework for managed languages
https://www.tornadovm.org
Apache License 2.0
1.18k stars 113 forks source link

Deprecate/Remove master-jdk17 branch #386

Closed jjfumero closed 5 months ago

jjfumero commented 5 months ago

Is your feature request related to a problem? Please describe.

Since TornadoVM moved to OpenJDK 21 with Panama Memory API, there is a compatibility issue with JDK 17. Thus, for known use cases using JDK17, TornadoVM had the option to run with jdk17 without the Panama integration. However, all known uses cases for TornadoVM as well as running projects (e.g., AERO), are running with JDK21+, so there is no need to maintain the old one.

Besides, with JDK22, the JVMCI/GraalVM integration has also changed, which means that TornadoVM will have a new branch as well for JDK22+ changes.

Describe the solution you'd like

I suggest removing the JDK 17 branch and focus to 21 as minimum from now on.

Describe alternatives you've considered

n/a.

Additional context n/a.

mikepapadim commented 5 months ago

Lets remove it as we have support with the latest LTS(21).

Also, as we add support for JDK22 which does not have backwards compatiblity due to graalvm paths change, we will end up maintaining 3 different jdks version (17, 21, 22).

I agree, then lets remove it.

kotselidis commented 5 months ago

I agree lets remove it for the aforementioned reasons.

jjfumero commented 5 months ago

OK, I am deleting the branch.