search

beehive-lab / TornadoVM

TornadoVM: A practical and efficient heterogeneous programming framework for managed languages
https://www.tornadovm.org
Apache License 2.0
1.18k stars 113 forks source link

[refactor] loopIndexInWrite implementation moved to its root interface #474

Closed jjfumero closed 3 months ago

jjfumero commented 3 months ago

Description

loopIndexInWrite implementation moved to its root interface since the implementation is identical for all device/backend types.

Problem description

n/ a.

Backend/s tested

Mark the backends affected by this PR.

OS tested

Mark the OS where this PR is tested.

Did you check on FPGAs?

If it is applicable, check your changes on FPGAs.

How to test the new patch?

This PR affects batch processing:

tornado -ea  --jvm "-Xmx6g -Dtornado.recover.bailout=False -Dtornado.unittests.verbose=True "  -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  --params "uk.ac.manchester.tornado.unittests.batches.TestBatches"
make tests
mairooni commented 3 months ago

Thanks @jjfumero! Just remove the * import from the VirtualOCLTornadoDevice.java as well.

jjfumero commented 3 months ago

We need to take a look at our default template for code formatting.