Closed jkressel closed 7 months ago
Hi, as we discussed through email with you and @lgeek, lets start with these changes:
Also the name of the pull request does not reflect what it is actually doing.
BRANCH_FSPACE
and the other with Atomic increment.jal_riscv
, which needs to be in a separate commit. Also includes some code that was uncommented in plugins/branch_count.c
which I think it should not have been commented out in the first place.cnd_branch_print.c
is done and working, its commit should be something like "Plugin to print conditional branches"@GuillermoCallaghan @lgeek I have fixed the commit situation, so that each feature is a commit
Hi @jkressel. Thanks again for the patches. I think this pull request will be getting very unwieldy if we continue using it for code review, there are many commits, quite a bit of code, and IIRC any time you force push an update, the entire code review will be collapsed so it will be difficult to keep track of what's been done. This is why I was asking for several pull requests more narrow in scope in my initial email. We need to split it up into at least 3 separate pull requests:
Basically create two new branches based on the riscv branch in this repository and cherry-pick the commits I've mentioned. Then open a new pull request for each branch.
My recommendation would be to leave the plugins aside until we get everything else merged and focus on the other patches. Since @GuillermoCallaghan started to review the plugins in this pull request, we can leave it open for them.
@lgeek @GuillermoCallaghan okay I'll create some new pull requests for those commits
I have included the increased size of BRANCH_FSPACE as well as the plugins, since this allows the plugins to run correctly