beejjorgensen / bgnet

Beej's Guide to Network Programming source
962 stars 130 forks source link

Initial Korean translation + build script patch pull request. #23

Closed garrettjavalia closed 7 months ago

garrettjavalia commented 1 year ago

I am a programmer who have read your socket programming guide long time ago. Its been almost 9 years ago from the first time that I have found your document and it`s korean translation versions (the korean translation version that I have read was made in 1999)

I tried to translate your document few times and this is the most far achievement I have done through my many trys.

please check this pull request and give me any ideas/opinions.

this pull request has three main changes:

I want to make a better way to share this translation with other people, and I thought pushing this to main repository could be a way for it. thank you.

beejjorgensen commented 10 months ago

This is looking generally awesome, but when I try to build the original site on your branch, the encoding is off and the CSS is missing...?

garrettjavalia commented 10 months ago

Thank you for checking! I will try to fix it. It would be great if you tell me what is encoding that you have mentioned on the comment.

garrettjavalia commented 9 months ago

I have tested the problem by building the english version in my latest branch but I were not able to reproduce the problem. home page were builded fine. However, It might be the tool chain and build script problem I guess. Below are few things that I have found during the inspecting of problem.

  1. The main build command docker build -t beej-bgnet-builder . in the root directory fails even in the commit b8b2b756ee59eb7d11b42833321dd572feb824b2 ("up ver" by @beejjorgensen ) which is latest commit that my PR is based on.
  2. I had to fix some problems of your build script, but I guess all of those problems were happened by update of build toolchains. (If not, how did the original build scripts could work and generate the website?))
  3. So I guess if you were using local toolchain instead of the dockerized one, that could cause the problem due to mismatch of my updated script/files and your toolchain.

please let me know if the dockerized version were still causing problem. ( It should not be the problem but I am using docker in windows.)

I am really thankful for your comment and I'm going to continue the translation work.

garrettjavalia commented 7 months ago

I will open pullrequest again someday later when I finish the initial translation. This branch is too messy for a PR.