search

beekai-oss / react-simple-animate

🎯 React UI animation made easy
https://react-simple-animate.now.sh/
MIT License
1.82k stars 61 forks source link

Feature Request: Pass className to animation #50

Closed GeorgeWL closed 5 years ago

GeorgeWL commented 5 years ago

I don't know if this is outside of the scope of this more lightweight module, but it would be nice if possible to allow one to set a className prop that applies a css class instead of using a style object.

bluebill1049 commented 5 years ago

hey @GeorgeWL

oh yeah, that's possible. but I guess that defeats the purpose of this little library because you are basically toggling the className. you can already do that in React.

I actually wrote a blog about why I didn't do toggle className https://medium.com/jsdownunder/react-ui-animation-made-simple-c2ff98056659

but I am sure you have your reasons, I would love to hear your concern as well see if I can make something works for you as well :)

GeorgeWL commented 5 years ago

Yeah you've a point there tbh.

Only reason for it I can think possibly is adding a class name only on componentWillUnmount, but that's too much of an edge case and can be done just as easily with changing the props for the animation instead.

Feel free to close it

Kind Regards,

George W Langham

On Fri, 31 May 2019, 10:50 pm Bill, notifications@github.com wrote:

hey @GeorgeWL https://github.com/GeorgeWL

oh yeah, that's possible. but I guess that defeats the purpose of this little library because you are basically toggling the className. you can already do that in React.

I actually wrote a blog about it as well https://medium.com/jsdownunder/react-ui-animation-made-simple-c2ff98056659

but I am sure you have your reasons, I would love to hear your concern as well see if I can make something works for you as well :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bluebill1049/react-simple-animate/issues/50?email_source=notifications&email_token=ABNIB4G2UEO3P32RHVIJHVLPYGMRBA5CNFSM4HR3G5XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWWOR3Q#issuecomment-497871086, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNIB4GDZUZPRKTYPRXET6DPYGMRBANCNFSM4HR3G5XA .

bluebill1049 commented 5 years ago

ha thanks for understanding @GeorgeWL feel free to leave more feedback in the future :)

have a good weekend bill

GeorgeWL commented 5 years ago

Yeah I had a feeling it may be out of scope

Kind Regards,

George W Langham

On Sat, 1 Jun 2019, 12:40 pm Bill, notifications@github.com wrote:

Closed #50 https://github.com/bluebill1049/react-simple-animate/issues/50.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bluebill1049/react-simple-animate/issues/50?email_source=notifications&email_token=ABNIB4FAO5ALGR6F2EPVMR3PYJN3HA5CNFSM4HR3G5XKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORYCJSPI#event-2382666045, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNIB4FR7KFE3LUUV74MA5TPYJN3HANCNFSM4HR3G5XA .