beekai-oss / react-simple-img

🌅 React lazy load images with IntersectionObserver API and Priority Hints
MIT License
989 stars 41 forks source link

Dependency issue installing via Yarn #18

Closed dustinkerstein closed 6 years ago

dustinkerstein commented 6 years ago

I have no issues when installing via NPM, but with Yarn I get:

$ yarn add react-simple-img@beta
yarn add v0.24.5
warning pano_moments@1.0.0: No license field
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "react-simple-img@1.3.6-beta.1" has incorrect peer dependency "react@>=15.6.1".
warning "react-simple-img@1.3.6-beta.1" has incorrect peer dependency "react-dom @>= 15.6.1".
warning "react-simple-img@1.3.6-beta.1" has unmet peer dependency "prop-types@^1 5.6.0".
warning "react-simple-animate@1.9.0" has incorrect peer dependency "react@>= 15. 6.1".
warning "react-simple-animate@1.9.0" has incorrect peer dependency "react-dom@>= 15.6.1".
[4/4] Building fresh packages...
success Saved 0 new dependencies.
warning pano_moments@1.0.0: No license field
Done in 15.37s.

Which results in this error:

Error: Cannot find module 'prop-types'

bluebill1049 commented 6 years ago

i have moved prop-types out from peer dependencies 1.3.6-beta.2.

hopefully i get sometimes to upgrade with the new context API, so prop-types can be removed.

let me know if that fix your issue

dustinkerstein commented 6 years ago

Cool, will try to give this a try tomorrow.

dustinkerstein commented 6 years ago

I seem to get this error on the latest beta:

Uncaught ReferenceError: regeneratorRuntime is not defined

bluebill1049 commented 6 years ago

what about 1.3.6?

dustinkerstein commented 6 years ago

What's the tag name for that? I think I tried the latest beta.

bluebill1049 commented 6 years ago

that's latest version mate. 1.3.6 no beta

dustinkerstein commented 6 years ago

Is it in both npm and Yarn repos?

bluebill1049 commented 6 years ago

yea

dustinkerstein commented 6 years ago

This is what I see in when adding via Yarn:

image

Do you mean the beta2?

bluebill1049 commented 6 years ago

closed by accident, forgot to publish 1.3.6

bluebill1049 commented 6 years ago

your issue could be babel polyfill version this is the version i have in react simple img: "babel-polyfill": "^6.26.0" made it peer dependency. hope this will resolve the issue.

dustinkerstein commented 6 years ago

Just upgraded to 1.3.7 and looking good so far. Thanks!