search

beekai-oss / react-simple-img

🌅 React lazy load images with IntersectionObserver API and Priority Hints
MIT License
989 stars 41 forks source link

animationDuration not working #39

Closed xbreid closed 5 years ago

xbreid commented 5 years ago

Hello! Awesome component. I noticed however that the animation transition doesn't seem to be working, I install react-simple-animation as well to see if that would fix it. But still got nothing.

Anyone else had this issue?

bluebill1049 commented 5 years ago

Thanks heaps :) @bar0191 which version you have right? i had fixed a bug couple days ago with a patch. current version is 1.5.4/

bluebill1049 commented 5 years ago

do you mean duration or just the animation is completely not working at all?

xbreid commented 5 years ago

it seems like the animation just isn't working at all, the placeholder will flash out, and I set the animationDuration to something high like 10s and noticed it didn't work.

I'm on version 1.5.4 react 16.7 on Gatsby 2.0.77

bluebill1049 commented 5 years ago

hmmm... can i have a look at your code snippet?

xbreid commented 5 years ago

sooo with a little more testing, the component is fine! It's a HOC I have wrapped around the image component that's making the animation not trigger

update: looks like if I try to change the height of the img directly, it causes the animation to not trigger

xbreid commented 5 years ago

Closing this since it looks like I just had to fix some css issues. Sorry for the troubles!

bluebill1049 commented 5 years ago

haha no worries 👍