search

beekai-oss / react-simple-img

🌅 React lazy load images with IntersectionObserver API and Priority Hints
MIT License
989 stars 41 forks source link

Number.isNaN not supported in IE11 #54

Closed kyle-mccarthy closed 5 years ago

kyle-mccarthy commented 5 years ago

Describe the bug Number.isNaN is not supported in IE11 but is used it https://github.com/bluebill1049/react-simple-img/blob/master/src/utils/getAspectRatio.js#L13

Expected behavior Polyfill Number.isNaN or use alternative strategy

Desktop (please complete the following information):

bluebill1049 commented 5 years ago

thanks for reporting :) i have fixed the issue on https://github.com/bluebill1049/react-simple-img/releases/tag/v2.1.9

kyle-mccarthy commented 5 years ago

Thanks for resolving this so quickly! The new version resolves the problem.

bluebill1049 commented 5 years ago

thank you for the star and support ❤️