beekai-oss / react-simple-img

🌅 React lazy load images with IntersectionObserver API and Priority Hints
MIT License
989 stars 41 forks source link

Add browser support to README #71

Closed davidjerleke closed 5 years ago

davidjerleke commented 5 years ago

Is your feature request related to a problem? Please describe. I can see that the library is using the Intersection Observer API. Does that mean that browser support is equivalent to browsers that support Intersection Observer? Or do you use a polyfill?

Describe the solution you'd like Add browser support list to README. This would allow developers browsing this library to instantly see what browsers are supported, and not have to look in the source code which can be time consuming.

bluebill1049 commented 5 years ago

hey @davidcetinkaya

it's already listed in the feature:

Simple usage and tiny size includes polyfill (minified + gzipped)

davidjerleke commented 5 years ago

@bluebill1049, maybe I'm missing something very obvious 🙈, but where do you read that?

bluebill1049 commented 5 years ago

feature list.

bluebill1049 commented 5 years ago

last one

davidjerleke commented 5 years ago

Thanks for clarifying 🙂. Sorry, now I see 👍. Although I think something like this would help:

2

But maybe that's just me. Feel free to add this if you think it could help others too.

Thank you for your attention! David

bluebill1049 commented 5 years ago

This package support majority of the browsers include ie11. But feel free to submit a PR to clarify this.

davidjerleke commented 5 years ago

Thank you. I have to try the library first in order to determine browser support and submit a PR.

bluebill1049 commented 5 years ago

that would be lovely! thanks

bluebill1049 commented 5 years ago

going to close this issue for now, feel free to send a PR to correct that in the near future