Height and width not accepting %

beekai-oss / react-simple-img

🌅 React lazy load images with IntersectionObserver API and Priority Hints

MIT License

989 stars 41 forks source link

Height and width not accepting % #80

Closed quochuy closed 5 years ago

quochuy commented 5 years ago

Describe the bug With 2.3.3 we used to be able to pass height="100%" but since height and width are now set as number this is now throwing a type error.

To Reproduce <SimpleImg src={src} height="100%" width="100%" />

Expected behavior Should allow us to use a string as well as number.

Screenshots Screen Shot 2019-09-17 at 11 43 10 am

bluebill1049 commented 5 years ago

thanks the issue has been patched.