Handle errors thrown when trying to use sessionStorage

beekai-oss / react-simple-img

🌅 React lazy load images with IntersectionObserver API and Priority Hints

MIT License

989 stars 41 forks source link

Closed seankarson closed 5 years ago

seankarson commented 5 years ago

Some browsers have settings which users can enable that block the use of sessionStorage.
See https://www.chromium.org/for-testers/bug-reporting-guidelines/uncaught-securityerror-failed-to-read-the-localstorage-property-from-window-access-is-denied-for-this-document for an example
To fix this, let's try-catch the usages of sessionStorage, as it appears to only be needed to enable the non-essential configuration option that disables animation for cached images

bluebill1049 commented 5 years ago

thanks a lot for the PR :)

seankarson commented 5 years ago

@bluebill1049 Back to you! Thanks!

bluebill1049 commented 5 years ago

thanks very much @seankarson

bluebill1049 commented 5 years ago

I will publish this tonight 👍