search

beeldengeluid / beng-lod-server

LOD server for B&G catalogue
MIT License
1 stars 1 forks source link

Bug: Blank nodes for roles have type Resource, instead of type Role or PerformanceRole #297

Closed mwigham closed 1 year ago

mwigham commented 2 years ago

Persons are linked to a programme via a role, which is a blank node. This should have type Role or PerformanceRole, however it has type Resource

wmelder commented 2 years ago

I think this was fixed earlier. Can you list some examples?

wmelder commented 2 years ago

for example: is this oké?

curl -v -L -H "Accept: application/n-triples" http://data.beeldengeluid.nl/id/program/2102203150335388131
wmelder commented 2 years ago

Ofcourse this is more readabel: 

curl -v -L -H "Accept: text/turtle" http://data.beeldengeluid.nl/id/program/2102203150335388131
mwigham commented 2 years ago

I fixed this in the pull request I submitted earlier today https://github.com/beeldengeluid/beng-lod-server/pull/302

mwigham commented 2 years ago

It is odd that it apparently works for the production version of the beng-lod-server, but not for the version in main, and also not in the triplestore

wmelder commented 2 years ago

I think the triple store is a little behind. It is strange the production version differs. Somehow it was fixed, but changes not pushed?

mwigham commented 2 years ago

Was a branch deployed perhaps?

wmelder commented 1 year ago

@mwigham I checked the version we just deployed and it contains a PerformanceRole.

curl -v -L -H "Accept: text/turtle" http://data.beeldengeluid.nl/id/program/2102203150335388131

Could you please check whether it now is ok? Perhaps your fix is not needed anymore? Then it would make https://github.com/beeldengeluid/beng-lod-server/pull/302 a more singular PR.

mwigham commented 1 year ago

Works fine!