Closed mwigham closed 3 years ago
@wmelder could you test this please? Test plan:
Here is an example for programs containing politicians from the VVD: and for extreme-right politicians:
It is odd that so many titles are not present, I will create an issue to look into this.
It is odd that so many titles are not present, I will create an issue to look into this.
I think I found (just slightly discovering this matter some time ago) that when a title is missing, the season or series title is a good alternative. Properly also a reason why they didn't provide a program title: via hierarchy the title is derived.
This is certainly a good alternative when the program title is missing. If it turns out that is the case for these programs, then we can use the same procedure.
@wmelder @mwigham does this still need review from Willem?
@mwigham was this story written before Willem's remark? (concerning the missing titles): https://github.com/beeldengeluid/beng-lod-server/issues/89
@jblom yes, it was. So that story will probably only require a quick check that this is indeed the reason for the missing titles, and a decision what the appropriate behaviour is for the API - i.e. get series titles in the same query or in a separate query.
Yes, this issue does still need review please.
Ik heb het testplan niet doorlopen, maar wel naar de titel issue gekeken:
{
"query": {
"ids": {
"type": "program_aggr",
"values": [
"4201246@program"
]
}
}
}
en deze heeft inderdaad wel een serie titel. Het betreft de wereld draait door, dus duidelijk waarom de uitzending zelf geen titel heeft. Zowel season als series heeft een titel: Het programma met id 4198758 is ook dwdd
Bedankt @wmelder , die issue heb ik ook in #89 bekeken en de issue gesloten
@mwigham
Ik heb geprobeerd de grlc-caching-120 branch uit te checken maar die bestaat niet (meer).
is het nog nodig dat ik het testplan doorloop of is deze story achterhaald?
@willem The branch has since been merged, so you can test this on the master. Thanks!
Currently, users can search for programmes with a certain person based on their name. They cannot find programs based on broader criteria, e.g. programmes with members of the political party CDA. A wikidata query that returns GTAA identifiers of persons meeting certain political criteria would make this possible.
Tasks:
Acceptance criteria: