beeldengeluid / beng-lod-server

LOD server for B&G catalogue
MIT License
1 stars 1 forks source link

As a developer, I need to write grlc queries that make it possible to find GTAA persons meeting certain political criteria #88

Closed mwigham closed 3 years ago

mwigham commented 4 years ago

Currently, users can search for programmes with a certain person based on their name. They cannot find programs based on broader criteria, e.g. programmes with members of the political party CDA. A wikidata query that returns GTAA identifiers of persons meeting certain political criteria would make this possible.

Tasks:

Acceptance criteria:

mwigham commented 4 years ago

@wmelder could you test this please? Test plan:

mwigham commented 4 years ago

Here is an example for programs containing politicians from the VVD: image and for extreme-right politicians: image

It is odd that so many titles are not present, I will create an issue to look into this.

wmelder commented 4 years ago
It is odd that so many titles are not present, I will create an issue to look into this.

I think I found (just slightly discovering this matter some time ago) that when a title is missing, the season or series title is a good alternative. Properly also a reason why they didn't provide a program title: via hierarchy the title is derived.

mwigham commented 4 years ago

This is certainly a good alternative when the program title is missing. If it turns out that is the case for these programs, then we can use the same procedure.

jblom commented 4 years ago

@wmelder @mwigham does this still need review from Willem?

jblom commented 4 years ago

@mwigham was this story written before Willem's remark? (concerning the missing titles): https://github.com/beeldengeluid/beng-lod-server/issues/89

mwigham commented 4 years ago

@jblom yes, it was. So that story will probably only require a quick check that this is indeed the reason for the missing titles, and a decision what the appropriate behaviour is for the API - i.e. get series titles in the same query or in a separate query.

Yes, this issue does still need review please.

wmelder commented 4 years ago

Ik heb het testplan niet doorlopen, maar wel naar de titel issue gekeken:

{
  "query": {
    "ids": {
      "type": "program_aggr",
      "values": [
        "4201246@program"
      ]
    }
  }
}

en deze heeft inderdaad wel een serie titel. Het betreft de wereld draait door, dus duidelijk waarom de uitzending zelf geen titel heeft. Zowel season als series heeft een titel: image image Het programma met id 4198758 is ook dwdd

mwigham commented 4 years ago

Bedankt @wmelder , die issue heb ik ook in #89 bekeken en de issue gesloten

wmelder commented 4 years ago

@mwigham
Ik heb geprobeerd de grlc-caching-120 branch uit te checken maar die bestaat niet (meer). is het nog nodig dat ik het testplan doorloop of is deze story achterhaald?

mwigham commented 4 years ago

@willem The branch has since been merged, so you can test this on the master. Thanks!