Include licence metadata on watch page

beeldengeluid / peertube-plugin-creative-commons

CC licenses plugin for PeerTube

https://beeldengeluid.github.io/extending-peertube/

GNU Affero General Public License v3.0

1 stars 1 forks source link

Include licence metadata on watch page #5

Closed phivk closed 3 years ago

phivk commented 3 years ago

include licence metadata on watch page by

inserting attributes to existing elements for Title and Author
inserting new link tag for Work URL.

closes #3

@frankstrater I couldn't find a more robust way to find the Video Author element than querying for '[title="Account page"]', which doesn't feel very future proof. Any ideas for less brittle ways to approach this?

frankstrater commented 3 years ago

@frankstrater I couldn't find a more robust way to find the Video Author element than querying for '[title="Account page"]', which doesn't feel very future proof. Any ideas for less brittle ways to approach this?

I'm looking into this for all HTML node selections. You could ask the PeerTube developers through https://framagit.org/framasoft/peertube/official-plugins/-/issues or via their chat room https://app.element.io/#/room/#peertube:matrix.org

Could you also merge the new master in this branch and adjust you code accordingly?

phivk commented 3 years ago

sure, I'll merge master into this branch and implement your feedback on top of that.

phivk commented 3 years ago

@frankstrater I just merged in master and noticed that the licence icon element is no longer inserted in the first div.video-info-date-views element that is displayed on narrow screens.

1E70E7BB-2AC2-4B65-84DE-4E335B08759B-500-00003DED61A139A8

I haven't yet found out why this is. Could you have a look?

frankstrater commented 3 years ago

I noticed this as well. Can you make a separate issue for this, so we can fix this in another branch?

@phivk EDIT; nevermind, already fixed it.