search

beeldengeluid / whisper-asr-worker

MIT License
2 stars 0 forks source link

Provenance #101

Closed greenw0lf closed 1 month ago

greenw0lf commented 1 month ago

Closes #81

greenw0lf commented 1 month ago

Maybe it'd be nice for you @mwigham to review this PR since you also worked with provenance, but for the ASR exporter. I made some choices that I'm not so sure are the best in terms of what to report and in what field of the provenance.

And I know the target branch is service-decouple and not main, but I built on top of that so I didn't want you to have to bother with reviewing those changes as well.

jblom commented 1 month ago

@greenw0lf @mwigham ok I've globally checked the code and comments here and it seems fine to merge it to the "dane as a service branch". From there I'll also test the code a bit more thoroughly and then merge with main, so we can try it out later this week.