search

beellz / infra-ansible

ansible assignment
0 stars 0 forks source link

Review Comments #1

Open anjuls opened 3 years ago

anjuls commented 3 years ago
  1. Readme file can be improved and can be written in a proper markdown.
  2. You are not using dynamic inventory? See if you can use it to automatically get the IP address
  3. Avoid hardcoded path /home/beellz/ansible-basic/ in the playbook.
  4. Password is exposed in connectsql.sh, you could have used Ansible vault.
NiniiGit commented 3 years ago

Maybe you can use the below links to understand how to use markdown if not already aware. https://www.markdownguide.org/cheat-sheet/ https://www.markdownguide.org/basic-syntax/