search

beeman / angular-elements-chat-widget

💬 Chat Widget built with Angular Elements
https://angular-elements-chat-widget.now.sh/
MIT License
129 stars 36 forks source link

fix(style): correct border #1

Closed Haroenv closed 6 years ago

Haroenv commented 6 years ago

This is quite noticeable on Safari, where the default style is unsightly:

screen shot 2018-05-02 at 08 44 31

Also added a focus style, but wasn't too sure about the color. White isn't super visible, but the change in size is. Feel free to suggest a change there.

beeman commented 6 years ago

Hey @Haroenv, thanks for your contribution!

Let's update the css like this, that way it looks good in Chrome and Safari :)

.chat-button:focus {
  border: 0;
}
Haroenv commented 6 years ago

Hey @beeman, if there's no visual indicator of focus, people who navigate with the keyboard won't know which element is focused, since you turned off the outline. I would suggest using a different color, but not 0

beeman commented 6 years ago

@Haroenv that makes total sense. Merging the PR as is! 👍

Haroenv commented 6 years ago

perfect! Feel free to change this later when there would be two configurable colours to the non-main color :)