search

beemanbp03 / LocalLinks

LocalLinks is a web application that gives the user local golf courses and weather forecasts within a specified radius
0 stars 0 forks source link

Design/Code Review 1 - Ryan Michaelis #4

Open MichaeliRM30 opened 3 years ago

MichaeliRM30 commented 3 years ago

Design/Code Review 1

​

Project: Local Links

​

Developer: Boulder Beeman @beemanbp03

​

Reviewer: Ryan Michaelis

​ Item Considerations Comments/Suggestions
Reviewer comments and suggestions go here. Each item should have at least one "kudos" and two suggestions for improvement
Problem Statement 1. Accurately describes project purpose
2. Is professional and free of typos, slang, etc.
3. Fully explains the problem and the solution
4. Is understandable by the average person		 1. Project purpose defined clearly and succinctly.
2. Only thing is your last sentence is somewhat redundant.
3. Solution is pretty adequately described. Could mention user creation and management, but user stories cover it well.
4. Very easy to understand.
Design Documentation 1. Navigation/flow through the application is logical and easy to use.
2. The order in which values are displayed are logical and easy to understand/use
3. The order in which the form fields entered are logical and easy to understand/use
4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens		 1. Wire frames are excellent and paint a great picture of the usage. Dumby data is a great touch too.
2. Everything makes sense to me and layouts look clean.
3. Forms are intuitive and professional.
4. I'm not certain if there is documentation for this specifically, but I think I get a good picture from your wire frames.
Data model/Database 1. Everything on the screens and problem statement/flow is represented in the model
2. There is at least one 1-to-many relationship.
3. The model represents good database design
1. I'm not certain I can find a model or SQL, but the Dao structure looks like you know what you're doing!
2. Not certain I can give you valuable feedback.
3. Model may be in progress.
Code 1. Proper Maven project structure is used
2. .gitignore file for IntelliJ Java projects has been implemented
3. There is not any redundant or copy/paste code in the JSPs or classes
4. Classes are appropriately-sized (no monster classes)
Property files are used appropriately: no hard-coded values
5. Logging statements are used rather than System.out.println and printStackTrace.
6. There are appropriate unit tests/code coverage.		 1. Modeled after the example and modified - smart.
2. .gitignore is there and looks good!
3. Fantastic progress on JSP's. Broke new ground too.
4. Good sizes - good structure!
5. Looks like logging is up and running - nice!
6. I see you also have your tests covered and passing - well done.
pawaitemadisoncollege commented 3 years ago

@MichaeliRM30 Any printlns or stack traces?