search

beemdevelopment / Aegis

A free, secure and open source app for Android to manage your 2-step verification tokens.
https://getaegis.app
GNU General Public License v3.0
8.88k stars 372 forks source link

Some strings are unable to be translatable #1018

Open enolp opened 1 year ago

enolp commented 1 year ago
Info
Steps to reproduce

Go to Settings and tap on "Language", then select any language except English. Now return to the entry screen and add a new entry by tapping on "+" button, then tap on "Create a new entry" and save the new entry as it is. An error message will be shown, "Secret is a required field."

What do you expect to happen?

"Secret is a required field." string should be translatable.

What happens instead?

"Secret is a requierd field" is shown in English because its string key is missing on values(-XXX_rXX)/strings.xml file(s)

Log
No logs are necessary.
Additional notes

Looking for that string on source I realized that EditEntryActivity.java file from java/com/beemdevelopment/aegis/ui/ contains some untranslatable strings. I tried to fix it myself by mimicking other strings, but I'm not a developer so I failed. I suggest to check if there are more untranslatable strings because of this issue.

alexbakker commented 1 year ago

Thanks for opening an issue about this. I've actually been working on some improvements for the field validation that'll also make these strings translatable. It's still a work in progress, but I've opened a draft pull request so that everyone knows this is being worked on: #1022.