beemdevelopment / Aegis

A free, secure and open source app for Android to manage your 2-step verification tokens.
https://getaegis.app
GNU General Public License v3.0
8.37k stars 355 forks source link

Increase version support to `4` for 2FAS backup import #1305

Closed alexandre-eliot closed 3 months ago

alexandre-eliot commented 3 months ago

Version 4 import of 2FAS backup was tested and successful with and without encryption without any code change

RESOLVE #1304

alexbakker commented 3 months ago

Thanks, but I'm a little bit confused by this PR. The title says version support is increased to 4, but the code change increases version support to 5. As far as I know, there is no version 5 of 2FAS' backup format.

alexandre-eliot commented 3 months ago

You are right, a version 5 of 2FAS backup does not exist yet. However when a version 5 comes out, the code acts as a security to indicate that a version was not tested and thus is not handled. So the code allows version 4 2FAS backups to be loaded in but no further version.