beeminder / BeeSwift

Official Beeminder for iOS app
Other
30 stars 6 forks source link

Use the complete width of the device when rendering gallery view #291

Closed theospears closed 2 years ago

theospears commented 2 years ago

Previously the gallery view was limited to 320px. This added large margins and meant descriptions were often unnecessarily truncated. Here we change the width calculation logic so items are always at least 320px, but will be wider if there is space. We continue to favor showing multiple columns over making items wider.

Test Plan: Viewed in both portrait and landscape in the simulator on the following devices:

Screenshots from before and after in portrait and landscape (iPhone 13 Pro Simulator, note notch is not shown). The light red rectangle is a manual redaction of a private goal. The "Goals" header is not visible. This also happens on master for me, and I don't believe is related to this change.

Before: before - portrait before - landscape

After: after - portrait after - landscape