beeminder / BeeSwift

Official Beeminder for iOS app
Other
29 stars 6 forks source link

Fix all compiler warnings #301

Closed theospears closed 1 year ago

theospears commented 1 year ago

This addresses the compiler warnings generated while building BeeSwift.

The majority of these are deprecation warnings. The code is updated according to the advice in the warnings. There were also a few changes to building and linking.

Test Plan: On a single device:

On devices with and without a notch:

krugerk commented 1 year ago

I turned off wifi and cell data on my Iphone, then refreshed a goal in the ios app, and this appeared: "Eror could not refresh graph". my only option was "OK".

Ah, yes. The app as is does not support an offline mode. And this Merge Request deals mostly with tackling some 'technical debt'. Previously an alert dialog was shown in the aforementioned scenario. Code was updated to present this dialog in a more modern way. Expected behavior is that the dialog is still shown like it was before (and that that segment of the code compiles without the 'this style of alert dialog is deprecated' warning).

Thanks for engagement!