search

beeminder / BeeSwift

Official Beeminder for iOS app
Other
30 stars 6 forks source link

Fix race condition crash when getting goal connections #414

Closed theospears closed 12 months ago

theospears commented 12 months ago

There is a mutable map linking goals to health kit data sources. While all writes to this were protected by a mutex, reads were not. It appears it is not safe to read from this connection while writing to it, so this lead to crashes. Fix by also wrapping the read.

Testing: Launched the app and checked it could sync goals

theospears commented 12 months ago

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.