Fix off-by-one error in Daystamp logic

beeminder / BeeSwift

Official Beeminder for iOS app

Other

30 stars 6 forks source link

Fix off-by-one error in Daystamp logic #435

Closed theospears closed 10 months ago

theospears commented 10 months ago

Previously the daystamp logic was treating events which fell exactly on the cut-off point as being part of the previous day. In fact they should be treated as part of the next day. This lead to Apple Health metrics being attributed to the wrong day.

Testing:

Wrote unit test for this case
With a stacked PR verified that healthkit metrics report correctly

theospears commented 10 months ago

master
- #434
- #435 👈
  - #436

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @theospears and the rest of your teammates on Graphite