Badge number doesn't update when logging in with new account

krugerk commented 1 month ago

### Desiderata
- [x] Is this too corner-casey to care? Answer: yes, no one has or should have multiple accounts
- [ ] Decide whether to fix it for hygienic reasons

Replicata

Log in with an account that will have beemergencies soon (UserA)
Log out
Log in with some other account (UserB)
Note the badge shows 0 to reflect the 0 beemergencies of UserB
Wait for a zeno reminder (from UserA)
Note the badge number now shows the UserA's number of beemergencies
Open the app. App fetches goals and updates the badge (again setting it to UserB's 0 beemergencies)

Expectata

That it show the number of beemergencies for UserB and only for UserB.

Resultata

It shows the number of beemergencies for UserA when Zenos are sent. (And then back to those for UserB when one opens the app.)

Circumventata

Open the app.

Nota Nebulosa

App version: 6.7 (46) from TestFlight
App/Device receives push/remote notifications only for the currently logged in account.
Krugerk sees in registering for remote notifications that there is a matching call to unregisterForRemoteNotifications that might be missing (upon logout). Or could it be a backend issue?

Cognata

376
149

Verbata: accuracy of beemergency count,

dreeves commented 1 month ago

This strikes me as too corner-casey to care. It has a fine workaround and no one logs in with different accounts on the same device anyway. But if there's an easy fix, or it's good hygiene to clean things up here, sure.

DukeCephalopod commented 1 month ago

@krugerk as written, expectata and resultata are not actually in conflict: the badge showing stale data is not (necessarily) indicative of any remote notifications being received for the wrong account — reword?

krugerk commented 1 month ago

The badge not being updated upon signing out was also an issue and was fixed with #149. With this issue, even after logging (userA) and after logging in (userB), the badge is being updated to reflect the beemergencies of userA. I am not sure at which point this stops but it seems to carry on for a day or two.

dreeves commented 1 month ago

expectata and resultata are not actually in conflict

I fixed that just now.

beeminder / BeeSwift