search

beeminder / BeeSwift

Official Beeminder for iOS app
Other
30 stars 6 forks source link

goalVC now also respects safe area #495

Closed krugerk closed 1 month ago

krugerk commented 1 month ago

goal view controller was not respecting the safe areas. This meant, for example, that the graph was partially hidden behind the Dynamic Island.

theospears commented 1 month ago

I've really appreciated the before/after screenshots you've included in some other PRs - could you add one here?

krugerk commented 1 month ago

I've really appreciated the before/after screenshots you've included in some other PRs - could you add one here?

sure.

This is what it looks like broken / currently:

safe area left safe area right

The data area though on the goal vc accounted for the safe area: data area already respecting left and right safe area

thanks to https://github.com/beeminder/BeeSwift/blob/a4b2744e67f7dbfe1e6d15eb3adc6a8a12327b55/BeeSwift/GoalViewController.swift#L132-L133 and https://github.com/beeminder/BeeSwift/blob/a4b2744e67f7dbfe1e6d15eb3adc6a8a12327b55/BeeSwift/GoalViewController.swift#L105-L106

theospears commented 1 month ago

This seems reasonable, although I wonder if the app should even support landscape mode on phones

krugerk commented 1 month ago

This seems reasonable, although I wonder if the app should even support landscape mode on phones

Yeah that could be worth the discussion. This has been broken since iPhone X! (Some apps do purposely have content scroll inside the safe area and behind the Dynamic Island or into the status bar area.) The app is (still) somewhat inconsistent about these sorts of things. Currently I am thinking we just iteratively clean it up, at least until the sweeping overhaul.

krugerk commented 1 month ago

mentioning #64, a table exclusive layout