search

beeminder / BeeSwift

Official Beeminder for iOS app
Other
30 stars 6 forks source link

using alamofireimage for transitions when loading thumbnails and graphs #513

Open krugerk opened 1 week ago

krugerk commented 1 week ago

It was already being used in the Today Extension view but not for the graphs and graph thumbnails elsewhere in the app. Using it simplifies the code and allows for easily adding transitions. When scrolling the gallery or loading a goal, the user experience is enhanced by using smooth rather than jarring animations and transitions.

theospears commented 1 week ago

I think this changes some current behavior which was intentional. In particular, the intended behavior is:

  1. The bee lemniscate only appears while beebrain is active (i.e. the goal is being recalculated in the backend asynchronously), it's not intended to show while images are loading. This matches the behavior of the web app.
  2. If we already have a graph image for a goal, but then get a new url from the server, don't show a loading screen, instead show the old graph until the new one is downloaded and ready.