search

beeminder / beemios

Beeminder iOS app
9 stars 3 forks source link

Showing duplicate goals #8

Closed dsernst closed 9 years ago

dsernst commented 10 years ago

My Beemios app lists two of my goals twice each, for no obvious reason. Beeminder.com correctly shows only one each though, suggesting this bug is specific to the app.

Trying to tap into one of the dupe'd goals for More Details always crashes the app.

The only obvious uniqueness of these two goals, compared with all my others, is that these two are the most recently created. One was created around 8/5/14, the other 9/15/14.

Happy to go into more detailed specifics to help debug, if needed :smile:

elovelan commented 10 years ago

I have this for one of my goals. I'll debug.

elovelan commented 10 years ago

I accidentally reloaded my goals (which fixes the issue) but I was able to reproduce this in the simulator by changing the slug on one of my goals (in the debugger). @dreeves, any chance that a goal's slug could change after it's been created? If not, have there been any mass data changes to slugs in the past few months that might have caused this?

Would it make more sense to key off of the goal's id (serverId) instead of the slug? serverId is used as the key in a number of places so it seems consistency might be useful.

bsoule commented 10 years ago

changing your slugs is a perq that comes with premium, but you'd have to do it on purpose.

I'll look to see if api output has changed.

B

On Tue, Sep 23, 2014 at 8:25 PM, Eric Loveland notifications@github.com wrote:

I accidentally reset my goals but I was able to reproduce this in the simulator by changing the slug on one of my goals (in the debugger). @dreeves https://github.com/dreeves, any chance that a goal's slug could change after it's been created? Have there been any mass changes in the past few months that might cause this?

— Reply to this email directly or view it on GitHub https://github.com/beeminder/beemios/issues/8#issuecomment-56620586.

http://bethaknee.com http://beeminder.com -- Reminders with a sting

elovelan commented 10 years ago

My pull request should prevent dupes going forward but it doesn't resolve existing duplicates. Would it make sense to build some duplicate checking logic into the app or is it better just to document somewhere that pressing Reload Goals in the settings screen resolves it?

dsernst commented 9 years ago

Confirmed that hitting "Reload Goals" on settings page fixed this. Didn't have a chance to do other debug.

On Tuesday, September 23, 2014, Eric Loveland notifications@github.com wrote:

My pull request should prevent dupes going forward but it doesn't resolve existing duplicates. Would it make sense to build some duplicate checking logic into the app or is it better just to document somewhere that pressing Reload Goals in the settings screen resolves it?

— Reply to this email directly or view it on GitHub https://github.com/beeminder/beemios/issues/8#issuecomment-56623387.