beeminder / blog

3 stars 2 forks source link

Unintended text wrapping in post lists #374

Closed narthur closed 3 weeks ago

narthur commented 1 year ago
### Desiderata
- [x] Narthur puts it how he intended
- [x] Bee opines

Screenshot_20230913_062327

Text wrapping around the images like this is a regression.

narthur commented 1 year ago

Fix deployed

dreeves commented 1 year ago

After: image

Are we sure we disliked the wrapping? Maybe it's nice? I don't know, I'm bad at aesthetics, but maybe Bee could weigh in unless you're sure it's better this way.

narthur commented 1 year ago

@dreeves Hmm, that definitely is how I intended it to work at small screen widths. I guess I should reconsider that choice?

narthur commented 1 year ago

@dreeves @bsoule Closing this now, since the original bug is fixed. If there's a desire to reconsider the design intention here let's create a new issue.

dreeves commented 1 year ago

Set me straight if I'm creating bad workflows but since this one has the screenshots and stuff I'd rather leave it open till Bee chimes in. She may say it's fine and we can just close this. But with this closed we have nothing to remind us to get a new gissue created if we do want to change something about this.

bsoule commented 8 months ago

after mobile / small scale is good:

Screen Shot 2024-03-06 at 15 26 14

after for the desktop / large scale is fine:

Screen Shot 2024-03-06 at 15 25 47

I maybe have a slight preference for the "before" version above, with the text wrapping around the image, except maybe because of the variablility of the length of the excerpts, it might be better the way it currently is?

like if some excerpts are long and wrap below the image, and then others are shorter and don't wrap, maybe that would look worse than the status quo? i have a slight, though not strong, prediction that it'd be ugly for some to have text below the image and others without (jsut cuz the excerpt is too short).